feat: ODP REST API for Sending ODP Events #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msohailhussain Let me know if you want to pair up over this review. |
msohailhussain
suggested changes
Oct 13, 2022
jaeopt
requested changes
Oct 14, 2022
jaeopt
requested changes
Oct 19, 2022
Thanks @jaeopt . Holding for @msohailhussain 's approval 😉 |
msohailhussain
suggested changes
Oct 19, 2022
|
@mikechu-optimizely Overall your PR looks good, please address 4 more questions and then lgtm. |
|
last but not least please fix Lint issues. |
It seems like the lint error here in the GitHub Action is about a missing auth token. Would you like me to pause the Pull Request and resolve this step, so we can make the "Csharp CI with .NET / Lint Code Base (pull_request)" required? ...or are there lint issues that I missed in the code? Can you direct me to an example file? |
|
this is fine for me, we should resolve token issue in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding module to provide an internal service for sending events to ODP's REST API.
Test plan
Issues